ENGDOCS-2245 #21059
ENGDOCS-2245 #21059
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
The settings parameters are now documented twice: in this guide, and on the Configure Settings Management page. The descriptions are worded slightly differently. I think we should either have a canonical reference, or publish them in multiple places but from a single source/include. Duplicated, almost identical descriptions are bound to deviate further.
sarahsanders-docker
left a comment
sarahsanders-docker
left a comment
There was a problem hiding this comment.
Left a few non-blocker comments and found one small typo, otherwise LGTM
|
Thanks @aevesdocker. This looks great. I've left some suggestions. Let me know if you have any questions |
Yes this didn't sit right with me either. I've now removed the tables, merged the paragraphs together and pointed them to the right docs place |
| description: Learn how to onboard your company and take advantage of all of the Docker products and features. | ||
| levels: [intermediate] | ||
| params: | ||
| featured: true |
There was a problem hiding this comment.
Should this be a featured guide?
There was a problem hiding this comment.
Well it is the first ever admin guide ✨ so perhaps it should be?
@usha-mandya, thoughts?
There was a problem hiding this comment.
Yes. It should be a featured guide. The Docker Compose guide has most views compared to DBC and Scout. So, happy to move one of those to the guides collection.
4 participants
Description
Adapts https://docs.google.com/document/d/1aMbLWzHKtIiWxOt1FarIRk-GUZVVIMUYwufYllohdIc/edit into our Guide format
Related issues or tickets
Reviews