Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Oct 9, 2024

Add an advanced devops guide for bake

@github-actions github-actions bot added hugo Updates related to hugo area/guides labels Oct 9, 2024
@netlify
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 80aea34
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67091a0c3004160008b8e245
😎 Deploy Preview https://deploy-preview-21085--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn marked this pull request as ready for review October 10, 2024 09:03
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Put some comments / suggestions

subjects: [devops]
levels: [advanced]
params:
time: 30 minutes
Copy link
Member

@crazy-max crazy-max Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be not be automated based on word count? I recall we add smth like this with Jekyll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's possible. We used to have it on all pages by default, but it wasn't very useful. And now the thinking had been that, since these are follow-along guides, maybe it isn't very representative. But I'm not sure the manual ones are very accurate either. And if we think the automatic estimations based on word count are too low, we could probably just 2x them for guides. I'll take a look

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make a custom one that would take multiple things into account:

  • word count (1x factor)
  • links (2x factor)
  • code blocks (3x factor)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some pages have videos, which makes this extra tricky :-/ We can't easily factor in the video length into the reading time, only option is probably to hard-code the video length in somewhere. Feels a bit too hacky.

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn requested a review from a team October 11, 2024 13:26
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

params:
time: 30 minutes
featured: true
image: /images/guides/bake.webp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thompson-shaun Is there some design decision pending for this image?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this asset, the current one is 🤌

@dvdksn dvdksn merged commit 2478e67 into docker:main Oct 17, 2024
14 checks passed
@dvdksn dvdksn deleted the bake-guide branch October 17, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants