-
Notifications
You must be signed in to change notification settings - Fork 8k
build: add bake guide #21085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add bake guide #21085
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Put some comments / suggestions
| subjects: [devops] | ||
| levels: [advanced] | ||
| params: | ||
| time: 30 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be not be automated based on word count? I recall we add smth like this with Jekyll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's possible. We used to have it on all pages by default, but it wasn't very useful. And now the thinking had been that, since these are follow-along guides, maybe it isn't very representative. But I'm not sure the manual ones are very accurate either. And if we think the automatic estimations based on word count are too low, we could probably just 2x them for guides. I'll take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make a custom one that would take multiple things into account:
- word count (1x factor)
- links (2x factor)
- code blocks (3x factor)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some pages have videos, which makes this extra tricky :-/ We can't easily factor in the video length into the reading time, only option is probably to hard-code the video length in somewhere. Feels a bit too hacky.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
crazy-max
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
| params: | ||
| time: 30 minutes | ||
| featured: true | ||
| image: /images/guides/bake.webp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thompson-shaun Is there some design decision pending for this image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this asset, the current one is 🤌
Add an advanced devops guide for bake