Use access_token_name rather than pat_name #21092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucadruda
approved these changes
Oct 9, 2024
craig-osterhout
approved these changes
Oct 9, 2024
Contributor
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
LGTM. Thank you. Let us know when it can be merged.
Member
|
Was this feature already shipped as "GA"? This may be / likely would be a breaking change for users that parse this file (not sure how to best version though; only real option would be to append new fields / possibly duplicate fields at the end). Is there a change log for these kind of changes? |
Member
Author
|
I reached out to @thaJeztah internally. If my explanations are good enough could we merge this? The changes are already in production. |
Contributor
|
Created a docs ticket (ENGDOCS-2259) to come back to this. Merging this PR as the change is already in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the list of fields of the CSV export from the Docker Hub usage dashboard.
The
pat_namehas been renamedaccess_token_nameas it not only contains personnal access token names but also upcoming organization access token names.Related issues or tickets
Reviews