Skip to content

Conversation

@Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented Oct 16, 2024

Description

Update the sample repository link. Both container.md and develop.md previously had different links.

It would be better to keep my repo link for easier maintenance and updates, similar to Bun.

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 800aa39
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/670fd2e453f6790008902699
😎 Deploy Preview https://deploy-preview-21134--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


```console
$ git clone https://github.com/dockersamples/c-plus-plus-docker.git
$ git clone https://github.com/Pradumnasaraf/c-plus-plus-docker.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we should prefer to refer to the dockersamples organization's repositories. Same should go for the Bun guide.

@ajeetraina do you have superpowers to fork the repository for the Bun guide (https://github.com/Pradumnasaraf/bun-docker) to the dockersamples org?

@Pradumnasaraf
Copy link
Contributor Author

Pradumnasaraf commented Oct 16, 2024

Got it, @dvdksn. We should then prefer dockersamples. I have updated the link for the Bun guide as well. Once Ajeet is done with Forking, we can update guides by merging this PR.

@docker-robot
Copy link

docker-robot bot commented Jan 14, 2025

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@dvdksn
Copy link
Contributor

dvdksn commented Jan 14, 2025

I now have access to the dockersamples org, so I have forked your repository there. Thanks for your patience :-)

@dvdksn dvdksn merged commit 644f43d into docker:main Jan 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants