-
Notifications
You must be signed in to change notification settings - Fork 8.1k
docs: Update a link in cpp/containerize.md #21134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
content/guides/cpp/containerize.md
Outdated
|
|
||
| ```console | ||
| $ git clone https://github.com/dockersamples/c-plus-plus-docker.git | ||
| $ git clone https://github.com/Pradumnasaraf/c-plus-plus-docker.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we should prefer to refer to the dockersamples organization's repositories. Same should go for the Bun guide.
@ajeetraina do you have superpowers to fork the repository for the Bun guide (https://github.com/Pradumnasaraf/bun-docker) to the dockersamples org?
|
Got it, @dvdksn. We should then prefer |
7677993 to
800aa39
Compare
|
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
|
I now have access to the dockersamples org, so I have forked your repository there. Thanks for your patience :-) |
Description
Update the sample repository link. Both container.md and develop.md previously had different links.
It would be better to keep my repo link for easier maintenance and updates, similar to Bun.
Reviews