Skip to content

Conversation

@ArieHein
Copy link
Contributor

Description

Christmas is early :) and i had some free time to go over all the documents and fix all spelling mistakes i have found.
Sorry in advance for giving you hard work checking so many files.

I recommend you add something like spelling and grammar step in the PR process on markdown files (i use cspell but there are others).

There also about 15 grammar fixes not included that are specific to US English (ex. Initialize) vs British English (ex. Initialise)
and since according to the docs you are using US grammar - https://docs.docker.com/contribute/style/grammar/
I can create a PR for that, but it might be a bit like a grammar police, so i didn't include it in this one.
Shout if you want that as well in a separate PR.

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/engine Issue affects Docker engine/daemon area/compose Relates to docker-compose.yml spec or docker-compose binary area/hub Issue affects Docker Hub area/build Relates to Dockerfiles or docker build command area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/extensions Relates to Docker Extensions area/contrib Relates to the Docker style guide and contribution guidelines area/scout Relates to Docker Scout area/guides labels Oct 24, 2024
@netlify
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 97b3c02
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/671a279948969900082ab258
😎 Deploy Preview https://deploy-preview-21230--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you!!!

We do have spell checking, in vale, but it seems like we could improve this part of our validation workflow.

Shout if you want that as well in a separate PR.

Yes, you're most welcome to open that PR.

Cheers, appreciate it!

@dvdksn dvdksn merged commit c17facc into docker:main Oct 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build Relates to Dockerfiles or docker build command area/compose Relates to docker-compose.yml spec or docker-compose binary area/contrib Relates to the Docker style guide and contribution guidelines area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/engine Issue affects Docker engine/daemon area/extensions Relates to Docker Extensions area/guides area/hub Issue affects Docker Hub area/scout Relates to Docker Scout area/security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants