add how-to page explaining usage of Compose provider services #22586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/compose
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
glours
force-pushed
the
add-howto-compose-providers
branch
from
30c0d26 to
681b018
Compare
ndeloof
reviewed
May 5, 2025
ndeloof
reviewed
May 5, 2025
ndeloof
reviewed
May 5, 2025
ndeloof
approved these changes
May 5, 2025
Contributor
ndeloof
left a comment
ndeloof
left a comment
There was a problem hiding this comment.
LGTM.
I'm not convinced by the "provider service" terminology. Those are all services, just some are managed by compose, some are managed by a provider
Contributor
Author
|
@ndeloof do you have a better terminology in mind? |
apply @ndeloof feedbacks Co-authored-by: Nicolas De loof <nicolas.deloof@gmail.com>
Contributor
|
I don't have a nice short name in mind, but "service managed by a provider". |
Contributor
Author
|
@aevesdocker your thoughts on this ☝️ |
aevesdocker
reviewed
May 8, 2025
sarahsanders-docker
pushed a commit
to sarahsanders-docker/docs
that referenced
this pull request
May 9, 2025
…#22586) <!--Delete sections as needed --> ## Description Add how-to page for Compose provider services explaining usage and configuration of this new feature allowing extending Compose behaviour ## Related issues or tickets https://docker.atlassian.net/browse/APCLI-1091 ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [x] Technical review - [x] Editorial review - [ ] Product review --------- Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com> Co-authored-by: Nicolas De loof <nicolas.deloof@gmail.com> Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add how-to page for Compose provider services explaining usage and configuration of this new feature allowing extending Compose behaviour
Related issues or tickets
https://docker.atlassian.net/browse/APCLI-1091
Reviews