-
Notifications
You must be signed in to change notification settings - Fork 8.1k
update mcp reference to v0.22.0 #23521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added markdown stubs for the new commands (double check if I didn't miss any 😅)
| aliases: | ||
| - /reference/cli/docker/mcp/feature/list/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ls is set as the canonical now, so redirecting list to ls
| aliases: | ||
| - /reference/cli/docker/mcp/server/list/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ls is set as the canonical now, so redirecting list to ls
| aliases: | ||
| - /reference/cli/docker/mcp/server/list/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
| datafile: docker_mcp_import | ||
| title: docker mcp import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this was a mistake and if docker mcp import should've been docker mcp server import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saucow Could you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see both docker mcp import and docker mcp server import in https://github.com/docker/mcp-gateway/tree/v0.22.0/docs/generator/reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will defer to @slimslenderslacks here as he has more context, but my understanding is docker mcp server import and docker mcp import do nothing today. When running this command I see the following
@slimslenderslacks are these deprecated commands we no longer support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@usha-mandya there's only docker mcp catalog import now. docker mcp server import and docker mcp import are both gone. I think we've not been deleting entries from docs/generator!
I can delete those entries now. Our automation is not catching these dangling entries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slimslenderslacks ah! I thought they were new commands; didn't consider looking if they were old commands that were removed 😄
I'll remove the markdown "stubs" from this PR, then the generated yaml and markdown would still be vendored here (until the next release), but won't be rendered in the docs.
| command: docker mcp import | ||
| short: Import a server | ||
| long: |- | ||
| Import and parse a server definition from an official MCP registry URL. | ||
| This command fetches the server definition from the provided URL, parses it as a ServerDetail, | ||
| converts it to the internal Server format, and displays the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.... because the command is importing a server ?
And there is a docker mcp server export (which looks to be the counterpart to this?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! There IS a docker mcp server import already 🤔 🤔
So why do we have both? that's confusing; should one be an alias for the other?
|
@thaJeztah The MCP team confirmed that v0.22.0 is included in the DD 4.48 release. We are good to move forward with the version updates discussed today. |
|
OK! Moved this out of draft, but double-check if I didn't miss adding stubs and all commands are there 😅 |
| github.com/docker/buildx => github.com/docker/buildx v0.29.1 | ||
| github.com/docker/cli => github.com/docker/cli v28.4.0+incompatible | ||
| github.com/docker/compose/v2 => github.com/docker/compose/v2 v2.39.4 | ||
| github.com/docker/docker => github.com/docker/docker v28.4.0+incompatible | ||
| github.com/docker/model-runner/cmd/cli => github.com/docker/model-runner/cmd/cli v0.1.44 | ||
| github.com/docker/scout-cli => github.com/docker/scout-cli v1.18.4 | ||
| github.com/moby/buildkit => github.com/moby/buildkit v0.25.0 | ||
| github.com/moby/moby => github.com/moby/moby v28.4.0+incompatible | ||
| github.com/docker/mcp-gateway => github.com/docker/mcp-gateway v0.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a look at removing the replace rules in a follow-up (looks like dependencies were currently pinned, and shouldn't be, but didn't want to put those changes in the same PR)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
@slimslenderslacks OK updated;
|
|
Thanks @thaJeztah. I still see the auto-generated MD files for |
|
Yes, correct; they are vendored (until the next release is tagged and vendored), but there's no stubs in the docs, so they won't be rendered in the docs. |
usha-mandya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@aevesdocker or I can merge this when DD 4.48 is ready to go live.
|
we can merge now 👍 |
Description
Related issues or tickets
Reviews