Skip to content

Conversation

@thaJeztah
Copy link
Member

Description

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit bb847bd
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/68e6d30bc70f850008b5322a
😎 Deploy Preview https://deploy-preview-23521--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the dependencies Vendoring, packaging updates label Oct 8, 2025
@thaJeztah thaJeztah changed the title update mcp refernce to v0.22.0 update mcp reference to v0.22.0 Oct 8, 2025
@github-actions github-actions bot added the area/cli Relates to the CLI client label Oct 8, 2025
Copy link
Member Author

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added markdown stubs for the new commands (double check if I didn't miss any 😅)

Comment on lines +6 to +7
aliases:
- /reference/cli/docker/mcp/feature/list/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ls is set as the canonical now, so redirecting list to ls

Comment on lines +6 to +7
aliases:
- /reference/cli/docker/mcp/server/list/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ls is set as the canonical now, so redirecting list to ls

Comment on lines 6 to 7
aliases:
- /reference/cli/docker/mcp/server/list/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment on lines 3 to 4
datafile: docker_mcp_import
title: docker mcp import
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this was a mistake and if docker mcp import should've been docker mcp server import

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saucow Could you confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see both docker mcp import and docker mcp server import in https://github.com/docker/mcp-gateway/tree/v0.22.0/docs/generator/reference

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defer to @slimslenderslacks here as he has more context, but my understanding is docker mcp server import and docker mcp import do nothing today. When running this command I see the following

@slimslenderslacks are these deprecated commands we no longer support?

Screenshot 2025-10-08 at 10 06 53 AM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@usha-mandya there's only docker mcp catalog import now. docker mcp server import and docker mcp import are both gone. I think we've not been deleting entries from docs/generator!

I can delete those entries now. Our automation is not catching these dangling entries.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slimslenderslacks ah! I thought they were new commands; didn't consider looking if they were old commands that were removed 😄

I'll remove the markdown "stubs" from this PR, then the generated yaml and markdown would still be vendored here (until the next release), but won't be rendered in the docs.

Comment on lines +1 to +7
command: docker mcp import
short: Import a server
long: |-
Import and parse a server definition from an official MCP registry URL.
This command fetches the server definition from the provided URL, parses it as a ServerDetail,
converts it to the internal Server format, and displays the results.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.... because the command is importing a server ?

And there is a docker mcp server export (which looks to be the counterpart to this?)

Copy link
Member Author

@thaJeztah thaJeztah Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! There IS a docker mcp server import already 🤔 🤔

So why do we have both? that's confusing; should one be an alias for the other?

@usha-mandya
Copy link
Member

@thaJeztah The MCP team confirmed that v0.22.0 is included in the DD 4.48 release. We are good to move forward with the version updates discussed today.

@usha-mandya usha-mandya requested a review from saucow October 8, 2025 13:36
@thaJeztah thaJeztah marked this pull request as ready for review October 8, 2025 13:44
@thaJeztah
Copy link
Member Author

OK! Moved this out of draft, but double-check if I didn't miss adding stubs and all commands are there 😅

Comment on lines +133 to +141
github.com/docker/buildx => github.com/docker/buildx v0.29.1
github.com/docker/cli => github.com/docker/cli v28.4.0+incompatible
github.com/docker/compose/v2 => github.com/docker/compose/v2 v2.39.4
github.com/docker/docker => github.com/docker/docker v28.4.0+incompatible
github.com/docker/model-runner/cmd/cli => github.com/docker/model-runner/cmd/cli v0.1.44
github.com/docker/scout-cli => github.com/docker/scout-cli v1.18.4
github.com/moby/buildkit => github.com/moby/buildkit v0.25.0
github.com/moby/moby => github.com/moby/moby v28.4.0+incompatible
github.com/docker/mcp-gateway => github.com/docker/mcp-gateway v0.22.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look at removing the replace rules in a follow-up (looks like dependencies were currently pinned, and shouldn't be, but didn't want to put those changes in the same PR)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@slimslenderslacks OK updated;

  • deleted docker mcp import
  • deleted docker mcp registry (noticed it's a hidden command)
  • deleted docker mcp registry convert (noticed it's a hidden command)
  • deleted docker mcp server import

@thaJeztah thaJeztah requested a review from usha-mandya October 9, 2025 01:04
@usha-mandya
Copy link
Member

Thanks @thaJeztah. I still see the auto-generated MD files for mcp import and mcp server import. I think these are fine to have for now and will be removed when the upstream docs generator is updated?

@thaJeztah
Copy link
Member Author

Yes, correct; they are vendored (until the next release is tagged and vendored), but there's no stubs in the docs, so they won't be rendered in the docs.

@usha-mandya usha-mandya added this to the 4.48 milestone Oct 9, 2025
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aevesdocker or I can merge this when DD 4.48 is ready to go live.

@aevesdocker
Copy link
Contributor

we can merge now 👍

@usha-mandya usha-mandya merged commit 80d57c3 into docker:main Oct 9, 2025
15 checks passed
@thaJeztah thaJeztah deleted the bump_mcp branch October 9, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Relates to the CLI client dependencies Vendoring, packaging updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants