engine: install: debian.md suggest using apt UI #23679
Conversation
Suggest using apt for user-interactive commands: - Replace apt-get invocation - Replace apt-cache madison invocation - Filter unofficial package names for removal to installed packages
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
area/engine
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
We've used apt-get until now because it has a stable ui and is more suitable for scripting... but then otoh we do encourage entering these commands discretely. And if you want a scripted installation there's a great source of inspiration at https://get.docker.com.
So I guess changing to apt should be fine. Any concerns @thaJeztah?
And we'd need to update the ubuntu docs with the same.
|
Yeah, Looking at the changes, I don't think switching to |
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
I like it!
apt update, install are unlikely to change, and we're not piping/parsing their output anyway so I don't think apt-get has any benefits.
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
Overall I'm +1 on switching these; I do think these docs are written expecting users to copy paste into interactive terminals, and users looking for the scripting version will need to understand and adapt them appropriately (as they will for all other software).
|
|
||
| ```console | ||
| $ for pkg in docker.io docker-doc docker-compose podman-docker containerd runc; do sudo apt-get remove $pkg; done | ||
| $ sudo apt remove $(dpkg --get-selections docker.io docker-compose docker-doc podman-docker containerd runc | cut -f1) |
There was a problem hiding this comment.
Why even filter? Doesn't apt have reasonable behavior when you ask it to remove packages that aren't installed? (I'm sure we've probably discussed this before and I've just forgotten 😅)
There was a problem hiding this comment.
all of the apt, apt-get, ... remove package tool actions bail out if a package does not exist. I would be in favor of just making the documentation more instructive "if apt complains that a package does not exist you should remove it from the command and try again". However, as this pull request goes, I remove the scripting of apt-get as it is replaced with apt, the intent is to keep the same errors and information, and at most the user will benefit slightly if they allow sudo to timeout due to slow network access or whatever situation they will just have the one sudo invocation with the update I propose.
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Let's do it! I'll do Ubuntu in a follow-up!
5 participants
Suggest using apt for user-interactive commands: