This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Migrate GCP plugin implementation to main repo#585
Merged
chungers merged 138 commits intodocker-archive:masterfrom Jun 12, 2017
Merged
Migrate GCP plugin implementation to main repo#585chungers merged 138 commits intodocker-archive:masterfrom
chungers merged 138 commits intodocker-archive:masterfrom
Conversation
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
When on GCP, the plugin can find the project and zone by querying the metadata server. Signed-off-by: David Gageot <david@gageot.net>
Since it's a bit complicated to force the IP address of a GCE instance, I decided to map the LogicalID to the instance name. Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Also be more lenient with provides properties. We now better support absolute/relative URIs Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: French Ben <frenchben@docker.com>
Added ability to connect to serial ports
Signed-off-by: David Gageot <david@gageot.net>
Add more VM properties
Add configuration example to README
Signed-off-by: David Chung <david.chung@docker.com>
Automation for docker image builds; proper version string
Signed-off-by: David Gageot <david@gageot.net>
Fix binary name
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Here's how a pet instance is different than a cattle one: + It was created with a LogicalID which is mapped to the name of instance + It's boot disk shouldn't be deleted when the instance is deleted + It should try to reuse a pre-existing disk named after the LogicalID suffixed with `-disk` Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Use instance's name as the disk name
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
Remove duplication
This should not be inferred from the LogicalID Signed-off-by: David Gageot <david@gageot.net>
The spec should say if boot disks should be deleted or reused.
Signed-off-by: David Gageot <david@gageot.net>
Signed-off-by: David Gageot <david@gageot.net>
spec.Init is used by InfraKit to supply per-instance customisation, often derived from a template. This is not necessarily a script, so store it both under "startup-script" and under "userdata" Signed-off-by: Rolf Neugebauer <rolf.neugebauer@docker.com>
Store spec.Init under "startup-script" and "userdata"
Support multiple disks
Signed-off-by: David Gageot <david@gageot.net>
…ks-support Improve support for multiple disks
…com/docker/infrakit.gcp into migration-gcp Migrate GCP code into main repo.
Signed-off-by: David Chung <david.chung@docker.com>
|
Please sign your commits following these rules: $ git clone -b "migration-gcp" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353665216
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
added 2 commits
June 10, 2017 14:45
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
- Coverage 48.86% 46.95% -1.91%
==========================================
Files 78 85 +7
Lines 5010 5552 +542
==========================================
+ Hits 2448 2607 +159
- Misses 2291 2667 +376
- Partials 271 278 +7
Continue to review full report at Codecov.
|
added 4 commits
June 10, 2017 17:37
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
FrenchBen
suggested changes
Jun 12, 2017
Contributor
FrenchBen
left a comment
There was a problem hiding this comment.
Overall LGTM but cannot be merged until the Makefile is cleaned up
| @echo "+ $@" | ||
| wget -O tf.zip https://releases.hashicorp.com/terraform/0.9.3/terraform_0.9.3_linux_amd64.zip && unzip tf.zip && mv terraform ./build | ||
|
|
||
| <<<<<<< HEAD |
Contributor
There was a problem hiding this comment.
Invalid git merge :P
Needs to be cleaned out first.
added 2 commits
June 12, 2017 12:36
Signed-off-by: David Chung <david.chung@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the code and history of the GCP (Google) instance plugin (etc.) into the main infrakit repo. With this, we are also starting a
pkg/provideras the way to organize different infrastructure providers. In the future, we will migrate the provider-specific code inpkg/plugin/instanceto follow this convention, because this new convention will scale better as each provider will contain implementations of multiple infrakit SPI, not just the interface SPI alone.docker/infrakit.GCPrepo and moves the files topkg/provider/google.@dgageot @FrenchBen