Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

VMware vCenter and vSphere plugin#606

Merged
chungers merged 3 commits intodocker-archive:masterfrom
thebsdbox:vsphere_plugin
Jun 26, 2017
Merged

VMware vCenter and vSphere plugin#606
chungers merged 3 commits intodocker-archive:masterfrom
thebsdbox:vsphere_plugin

Conversation

@thebsdbox
Copy link
Copy Markdown
Contributor

This is the initial PR for the VMware vCenter/vSphere plugin for Docker Infrakit.

This plugin uses the VMware govmomi library to interact with the SOAP XML APIs that allow VM provisioning on both vCenter and the vSphere hypervisor directly.

Code around the Label function and around tag search in the Describe function needs completing. Along with an update to the Makefile

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "vsphere_plugin" git@github.com:thebsdbox/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354369336
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 23, 2017

Codecov Report

Merging #606 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
+ Coverage   46.78%   46.84%   +0.06%     
==========================================
  Files          87       87              
  Lines        6197     6197              
==========================================
+ Hits         2899     2903       +4     
+ Misses       3003     3000       -3     
+ Partials      295      294       -1
Impacted Files Coverage Δ
pkg/rpc/mux/server.go 61.66% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 305def1...2605397. Read the comment docs.

@chungers
Copy link
Copy Markdown
Contributor

@thebsdbox
Thanks for the PR. Would you mind updating the vendor.conf for the govmomi package and run trash? You can install trash (https://github.com/rancher/trash) and run from the project folder. Then add the missing dependencies in vendor/ and commit. Thanks!

- Currently supports both VMware vCenter, and singular vSphere hosts.

Added capability to use the VM `annotation` field to hold groupID
Fixed the missing SHA as a part of the tag response, means scaler works correctly
Moved a number of errors to debug as they weren’t critical.
Removal of fatal errors, reported as errors through the plugin logging.
Notes updated to reflect fixes and additional todo

Signed-off-by: Dan Finneran <daniel.finneran@gmail.com>
Signed-off-by: Dan Finneran <daniel.finneran@gmail.com>
@chungers chungers merged commit 5129850 into docker-archive:master Jun 26, 2017
@thebsdbox thebsdbox deleted the vsphere_plugin branch June 30, 2017 17:03
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
chungers pushed a commit to chungers/infrakit that referenced this pull request Oct 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants