Skip to content
This repository was archived by the owner on Jan 21, 2020. It is now read-only.

Add the VMware vSphere plugin to the Makefile#613

Merged
kaufers merged 3 commits intodocker-archive:masterfrom
thebsdbox:vSphere-Makefile
Jun 30, 2017
Merged

Add the VMware vSphere plugin to the Makefile#613
kaufers merged 3 commits intodocker-archive:masterfrom
thebsdbox:vSphere-Makefile

Conversation

@thebsdbox
Copy link
Copy Markdown
Contributor

Added in the additional lines to the Makefile which will compile the VMware vSphere plugin to the build directory.

Signed-off-by: Dan Finneran daniel.finneran@gmail.com

Signed-off-by: Dan Finneran <daniel.finneran@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2017

Codecov Report

Merging #613 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #613   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files          87       87           
  Lines        6197     6197           
=======================================
  Hits         2903     2903           
  Misses       3000     3000           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8080c9...e09bb88. Read the comment docs.

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "vSphere-Makefile" git@github.com:thebsdbox/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353879464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Copy link
Copy Markdown
Contributor

@kaufers kaufers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaufers kaufers merged commit 79b47e1 into docker-archive:master Jun 30, 2017
@thebsdbox thebsdbox deleted the vSphere-Makefile branch June 30, 2017 17:03
chungers pushed a commit to chungers/infrakit that referenced this pull request Sep 30, 2017
Fixes docker-archive#613

Signed-off-by: David Gageot <david@gageot.net>
chungers pushed a commit to chungers/infrakit that referenced this pull request Oct 1, 2017
Fixes docker-archive#613

Signed-off-by: David Gageot <david@gageot.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants