Remove unnecessary string formats#1568
Merged
aboch merged 2 commits intomoby:masterfrom Dec 29, 2016
liketic:refactor
Merged
Conversation
Signed-off-by: Ke Li <kel@splunk.com>
aaronlehmann
reviewed
Dec 2, 2016
| func runContainerCreate(c *cli.Context) { | ||
| if len(c.Args()) == 0 { | ||
| fmt.Printf("Please provide container id argument\n") | ||
| fmt.Print("Please provide container id argument\n") |
aaronlehmann
reviewed
Dec 2, 2016
|
|
||
| if len(c.Args()) == 0 { | ||
| fmt.Printf("Please provide container id argument\n") | ||
| fmt.Print("Please provide container id argument\n") |
aaronlehmann
reviewed
Dec 2, 2016
| return NewTCPProxy(frontendAddr.(*net.TCPAddr), backendAddr.(*net.TCPAddr)) | ||
| default: | ||
| panic(fmt.Errorf("Unsupported protocol")) | ||
| panic(errors.New("Unsupported protocol")) |
There was a problem hiding this comment.
This can be panic("Unsupported protocol")
Signed-off-by: Ke Li <kel@splunk.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
fmt.Errorfif no arguments passed, replace it witherrors.New.For
t.Fatalfif no arguments passed, replace it witht.Fatal.For
t.Errorfif no arguments passed, replace it witht.Error.For
fmt.Fprintfif no arguments passed, replace it withfmt.Fprint.For
fmt.Printfif no arguments passed, replace it withfmt.Print.For
log.Printfif no arguments passed, replace it withlog.Print.Because the previous
*fare almost calls the function without format internally and do format before output, but if no arguments passed, the format is unnecessary.Happy to hear your comments. Thanks.