Avoid flakiness of TestLinkContainers#1846
Merged
mavenugo merged 1 commit intomoby:masterfrom Jul 21, 2017
Merged
Conversation
Author
|
not working yet |
fcrisciani
force-pushed
the
avoid-test-failure
branch
from
dc1a015 to
0de0ad7
Compare
Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
avoid-test-failure
branch
from
0de0ad7 to
73ebaef
Compare
Author
|
Run it 6 times in a row with success, maybe the problem was that some tests were locking the thread into a namespace of a container that then was being removed |
fcrisciani
changed the title
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve the flakiness of the TestLinkContainers.
From a code standpoint I don't see any way that the chain should not exists.
I noticed that some of the previous tests are not properly doing the check if they are running into a container.
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com