This repository was archived by the owner on Jul 18, 2025. It is now read-only.
[VSPHERE] Support multiple networks#4140
Merged
shin- merged 2 commits intodocker-archive-public:masterfrom Jul 13, 2017
Merged
Conversation
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
…ines to make machine panic Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
shin-
reviewed
Jul 7, 2017
| } | ||
| } | ||
| // d.Network needs to remain a string to cope with existing machines :/ | ||
| d.Network = d.Networks[0] |
Contributor
There was a problem hiding this comment.
Is this used anywhere else? If not, we may want to set it to empty string instead?
Contributor
Author
There was a problem hiding this comment.
looking at the output of machine inspect, I think its better to keep it compatible and fill it with something - to differentiate from a vm with no networking. (and yup, I'm going to be using no-network vm's in future)
Contributor
Author
There was a problem hiding this comment.
it seems that both and empty string, and a csv version makes the provisioning step break - I don't really have the tuits to test all the provisioners, so I'm hoping you'll let this pass for now :)
Contributor
Author
|
@shin- ? |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on some proxied host testing, so I wanted to use machine to create my proxy server....