Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

ssh: Adds HostKeyCallback#4174

Merged
shin- merged 2 commits intodocker-archive-public:masterfrom
andrestc:hostkeycallback
Jul 10, 2017
Merged

ssh: Adds HostKeyCallback#4174
shin- merged 2 commits intodocker-archive-public:masterfrom
andrestc:hostkeycallback

Conversation

@andrestc
Copy link
Copy Markdown
Contributor

@andrestc andrestc commented Jul 5, 2017

This PR updates the vendored golang.org/x/crypto and adds an insecure HostKeyCallback to the native ssh client config.

Related to #4172.

andrestc added 2 commits July 5, 2017 10:55
Signed-off-by: André Carvalho <asantostc@gmail.com>
Signed-off-by: André Carvalho <asantostc@gmail.com>
@SvenDowideit
Copy link
Copy Markdown
Contributor

@shin- LGTM

@shin-
Copy link
Copy Markdown
Contributor

shin- commented Jul 10, 2017

The ssh code warns against using it in production, but it used to be the default configuration, so that's what we're currently doing anyway. Moving forward, should we try to check the host key's validity?

@shin- shin- merged commit fcfbd11 into docker-archive-public:master Jul 10, 2017
@shin- shin- modified the milestones: 0.13.0, 0.12.2 Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants