Skip to content

Clarify install option in example#152

Merged
crazy-max merged 2 commits intodocker:masterfrom
rodrigc:readme-clarify-install
May 28, 2022
Merged

Clarify install option in example#152
crazy-max merged 2 commits intodocker:masterfrom
rodrigc:readme-clarify-install

Conversation

@rodrigc
Copy link
Copy Markdown
Contributor

@rodrigc rodrigc commented May 26, 2022

Signed-off-by: Craig Rodrigues rodrigc@crodrigues.org

@rodrigc rodrigc requested a review from crazy-max as a code owner May 26, 2022 10:47
Comment thread README.md Outdated
@rodrigc
Copy link
Copy Markdown
Contributor Author

rodrigc commented May 26, 2022

@crazy-max this line mentions https://github.com/docker/setup-buildx-action/blob/master/action.yml#L25

description: 'Sets up docker build command as an alias to docker buildx'

Does that need to be changed also?

Co-authored-by: CrazyMax <github@crazymax.dev>
Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org>
@crazy-max
Copy link
Copy Markdown
Member

@crazy-max this line mentions https://github.com/docker/setup-buildx-action/blob/master/action.yml#L25

description: 'Sets up docker build command as an alias to docker buildx'

Does that need to be changed also?

Yes please

@rodrigc
Copy link
Copy Markdown
Contributor Author

rodrigc commented May 26, 2022

Yes please

OK, done.

"docker build" is actually aliased to "docker build buildx"

Signed-off-by: Craig Rodrigues <rodrigc@crodrigues.org>
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit cafcc1d into docker:master May 28, 2022
@rodrigc rodrigc deleted the readme-clarify-install branch May 28, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants