Skip to content

[tests] TestNodeJoinWithWrongCerts#2255

Merged
aaronlehmann merged 1 commit intomoby:masterfrom
cyli:test-join-node-invalid-certs
Jun 14, 2017
Merged

[tests] TestNodeJoinWithWrongCerts#2255
aaronlehmann merged 1 commit intomoby:masterfrom
cyli:test-join-node-invalid-certs

Conversation

@cyli
Copy link
Copy Markdown
Contributor

@cyli cyli commented Jun 14, 2017

This is a followup to #2251.

Make sure that, when joining a cluster for the first time, if there are pre-generated certs in a directory if they do not match the cluster's certs, join fails immediately.

…re pre-generated

certs in a directory if they do not match the cluster's certs, join fails immediately.

Signed-off-by: Ying Li <ying.li@docker.com>
@aaronlehmann
Copy link
Copy Markdown
Collaborator

LGTM

@aaronlehmann aaronlehmann merged commit 723e570 into moby:master Jun 14, 2017
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 14, 2017

Codecov Report

Merging #2255 into master will increase coverage by 0.01%.
The diff coverage is 56.52%.

@@            Coverage Diff             @@
##           master    #2255      +/-   ##
==========================================
+ Coverage   60.31%   60.32%   +0.01%     
==========================================
  Files         124      124              
  Lines       20263    20265       +2     
==========================================
+ Hits        12221    12225       +4     
- Misses       6654     6663       +9     
+ Partials     1388     1377      -11

@cyli cyli deleted the test-join-node-invalid-certs branch June 14, 2017 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants