Skip to content

Bump go-winio to v0.4.2#2297

Merged
aaronlehmann merged 1 commit intomoby:masterfrom
thaJeztah:bump-go-winio
Jul 6, 2017
Merged

Bump go-winio to v0.4.2#2297
aaronlehmann merged 1 commit intomoby:masterfrom
thaJeztah:bump-go-winio

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Matches the version used in moby/moby

Full diff: microsoft/go-winio@f778f05...v0.4.2

Matches the version used in moby/moby

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 3, 2017

Codecov Report

Merging #2297 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2297      +/-   ##
==========================================
- Coverage    61.1%   61.02%   -0.08%     
==========================================
  Files         128      128              
  Lines       20549    20549              
==========================================
- Hits        12557    12541      -16     
- Misses       6607     6624      +17     
+ Partials     1385     1384       -1

@aaronlehmann
Copy link
Copy Markdown
Collaborator

LGTM

Would be really great if we could fix the docker/client -> go-connections/sockets -> go-winio dependency, though. Projects should be able to use the Docker API client with minimal extra libraries.

Looks like go-winio gets used for Windows named pipes. I'm not sure there's a good way to avoid that library, but it might make sense to refactor code so that the client library doesn't use it directly, and that responsibility falls on the application if it wants to support named pipes (that said, there's value to code automatically working on Windows).

@thaJeztah
Copy link
Copy Markdown
Member Author

@johnstep any thoughts on that?

@aaronlehmann aaronlehmann merged commit 50c6e8a into moby:master Jul 6, 2017
@thaJeztah thaJeztah deleted the bump-go-winio branch July 6, 2017 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants