Merged
Conversation
Matches the version used in moby/moby Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #2297 +/- ##
==========================================
- Coverage 61.1% 61.02% -0.08%
==========================================
Files 128 128
Lines 20549 20549
==========================================
- Hits 12557 12541 -16
- Misses 6607 6624 +17
+ Partials 1385 1384 -1 |
Collaborator
|
LGTM Would be really great if we could fix the Looks like |
Member
Author
|
@johnstep any thoughts on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the version used in moby/moby
Full diff: microsoft/go-winio@f778f05...v0.4.2