Skip to content

SEAB-6000: Propagate both the "added" and "removed" varieties of the "installation_repositories" event #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 27, 2024
Merged

SEAB-6000: Propagate both the "added" and "removed" varieties of the "installation_repositories" event #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7f9b08
propagate github app uninstalls
svonworl Mar 16, 2024
9e7ff7a
make less confusing
svonworl Mar 20, 2024
1ac034c
fix oopsie
svonworl Mar 21, 2024
d3c6fb0
fix repository name mapping
svonworl Mar 21, 2024
0d6fa07
modify lambda to process "removed" action for installation_repositori…
svonworl Mar 25, 2024
96938a8
placat style checkers
svonworl Mar 25, 2024
7d5020f
remove duplicate repository lines in pom
svonworl Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions upsertGitHubTag/deployment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,24 +166,19 @@ function processEvent(event, callback) {
var githubEventType = requestBody["X-GitHub-Event"];
// Handle installation events
if (githubEventType === "installation_repositories") {
// Currently ignoring repository removal events, only calling the endpoint if we are adding a repository.
if (body.action === "added") {
console.log("Valid installation event");
path += "workflows/github/install";
const repositoriesAdded = body.repositories_added;
const repositories = repositoriesAdded.map((repo) => repo.full_name);

postEndpoint(path, body, deliveryId, (response) => {
const successMessage =
"The GitHub app was successfully installed on repositories " +
repositories;
handleCallback(response, successMessage, callback);
});
} else {
console.log(
'installation_repositories event ignored "' + body.action + '" action'
);
}
// The installation_repositories event contains information about both additions and removals.
console.log("Valid installation event");
path += "workflows/github/install";
postEndpoint(path, body, deliveryId, (response) => {
const added = body.action === "added";
const repositories = (
added ? body.repositories_added : body.repositories_removed
).map((repo) => repo.full_name);
const successMessage = `The GitHub app was successfully ${
added ? "installed" : "uninstalled"
} on repositories ${repositories}`;
handleCallback(response, successMessage, callback);
});
} else if (githubEventType === "push") {
/**
* We only handle push events, of which there are many subtypes. Unfortunately, the only way to differentiate between them is to look
Expand Down
5 changes: 0 additions & 5 deletions wdl-parsing/WDLParsingFunction/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@
<url>https://repo.maven.apache.org/maven2</url>
<layout>default</layout>
</repository>
<repository>
<id>artifacts.oicr.on.ca</id>
<name>artifacts.oicr.on.ca</name>
<url>https://artifacts.oicr.on.ca/artifactory/collab-release</url>
</repository>
<repository>
<id>artifactory.broadinstitute.org</id>
<name>artifactory.broadinstitute.org</name>
Expand Down