Skip to content

Conversation

@Matteo-Omenetti
Copy link
Contributor

No description provided.

@mergify
Copy link

mergify bot commented Jan 29, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@Matteo-Omenetti Matteo-Omenetti changed the title WIP: Implementation of doc tags feat: Implementation of doc tags Feb 12, 2025
@Matteo-Omenetti Matteo-Omenetti marked this pull request as ready for review February 12, 2025 12:32
Ahmed Nassar and others added 18 commits February 12, 2025 14:41
Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@nassarofficial nassarofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Matteo-Omenetti Matteo-Omenetti merged commit f751b45 into main Feb 13, 2025
8 checks passed
@Matteo-Omenetti Matteo-Omenetti deleted the dev/ahn_dt branch February 13, 2025 13:26
muhark added a commit to muhark/docling-core that referenced this pull request Mar 19, 2025
* Migration to new DocTags, gt missing

Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com>

* fixed the tests

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* overloaded export to markdown in CodeItem to include code language

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* minor change

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* implemented page break token instead of page number

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* added figure classification in doc tags

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* changed table repr. to otsl

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* changed table repr. to otsl fixed new line

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* fixed new line bug

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* fixed new line bug

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* removed print in test

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* new normalization to 500 and top left coord

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* export of FOOTER AND HEADER

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* export of FOOTER AND HEADER

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* fix code bug

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* added export of standalon captions

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* added export of standalon captions

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* changed generate to False

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

* added export of furnitures and fixed bug in iterate_items function

Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>

---------

Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Co-authored-by: Ahmed Nassar <ahn@zurich.ibm.com>
Co-authored-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants