-
Notifications
You must be signed in to change notification settings - Fork 102
feat: Implementation of doc tags #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
54d1145 to
9bf7256
Compare
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
dolfim-ibm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nassarofficial
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Migration to new DocTags, gt missing Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com> * fixed the tests Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * overloaded export to markdown in CodeItem to include code language Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * minor change Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * implemented page break token instead of page number Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * added figure classification in doc tags Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * changed table repr. to otsl Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * changed table repr. to otsl fixed new line Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * fixed new line bug Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * fixed new line bug Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * removed print in test Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * new normalization to 500 and top left coord Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * export of FOOTER AND HEADER Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * export of FOOTER AND HEADER Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * fix code bug Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * added export of standalon captions Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * added export of standalon captions Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * changed generate to False Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> * added export of furnitures and fixed bug in iterate_items function Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> --------- Signed-off-by: Ahmed Nassar <ahn@zurich.ibm.com> Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com> Co-authored-by: Ahmed Nassar <ahn@zurich.ibm.com> Co-authored-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
No description provided.