Skip to content

Conversation

@Saidgurbuz
Copy link
Contributor

No description provided.

@Saidgurbuz Saidgurbuz requested a review from cau-git March 12, 2025 11:56
@maxmnemonic
Copy link
Contributor

very nice, we did some changes to dev/load_from_doctags, please rebase

Base automatically changed from dev/load_from_doctags to main March 12, 2025 15:11
@mergify
Copy link

mergify bot commented Mar 12, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
@Saidgurbuz Saidgurbuz force-pushed the dev/load_from_doctags_kv_item branch from d9014d2 to 28a9846 Compare March 12, 2025 15:54
@Saidgurbuz
Copy link
Contributor Author

very nice, we did some changes to dev/load_from_doctags, please rebase

Done!

@Saidgurbuz Saidgurbuz requested a review from maxmnemonic March 12, 2025 15:56
maxmnemonic
maxmnemonic previously approved these changes Mar 12, 2025
Copy link
Contributor

@maxmnemonic maxmnemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Saidgurbuz Saidgurbuz marked this pull request as ready for review March 12, 2025 16:16
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
@Saidgurbuz Saidgurbuz requested a review from maxmnemonic March 19, 2025 12:58
@Saidgurbuz Saidgurbuz merged commit 2371c11 into main Mar 19, 2025
8 checks passed
@Saidgurbuz Saidgurbuz deleted the dev/load_from_doctags_kv_item branch March 19, 2025 13:07
muhark added a commit to muhark/docling-core that referenced this pull request Mar 19, 2025
…ject#188)

* add kv_item support for doctag to docling_document

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>

* use resize_by_scale to save locations

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>

* add kv region to tag_to_doclabel

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>

* add test for doctags_load_for_kv_region

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>

* update the naming to .dt for consistency

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>

---------

Signed-off-by: Saidgurbuz <said.gurbuz@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants