Skip to content

Conversation

@ceberam
Copy link
Collaborator

@ceberam ceberam commented Nov 21, 2025

  • This PR enforces the use of single backticks in the markdown serialization of hyperlinks with text as code. The current implementation was using code blocks, while this is not allowed in markdown.
  • The revision 8e9ef03 has been tested with Docling version 2.63.0 and all tests pass.
  • In addition, some tests have been reorganized to favor the reuse of fixtures across modules
  • Function type annotation have been added in those functions that already held annotations in the function body. As a result, Mypy checks revealed some flaws that have been fixed.

It will #resolve# docling-project/docling#2647 as soon as the PR is merged and a new release is completed.

@mergify
Copy link

mergify bot commented Nov 21, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2025

DCO Check Passed

Thanks @ceberam, all your commits are properly signed off. 🎉

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ceberam ceberam removed the request for review from PeterStaar-IBM November 21, 2025 09:09
@ceberam ceberam force-pushed the fix/code-with-hyperlink-2647 branch from d585613 to b49e353 Compare November 21, 2025 09:22
Use fixtures for sample DoclingDocument in tests.
Add missing function type annotation when the body contains annotations.

Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
Signed-off-by: Cesar Berrospi Ramis <ceb@zurich.ibm.com>
@ceberam ceberam force-pushed the fix/code-with-hyperlink-2647 branch from b49e353 to 8e9ef03 Compare November 21, 2025 09:31
@ceberam ceberam marked this pull request as ready for review November 21, 2025 09:59
@dosubot
Copy link

dosubot bot commented Nov 21, 2025

Related Documentation

Checked 4 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@dolfim-ibm dolfim-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ceberam ceberam added the bug Something isn't working label Nov 21, 2025
@ceberam ceberam self-assigned this Nov 21, 2025
@ceberam ceberam merged commit 8feb09f into main Nov 21, 2025
13 checks passed
@ceberam ceberam deleted the fix/code-with-hyperlink-2647 branch November 21, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants