Create 0033-search-in-rotated-sorted-array.md #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanae772
reviewed
Oct 19, 2025
| else: | ||
| lo, hi = 0, min_index | ||
| target_index = bisect.bisect_left(nums, target, lo=lo, hi=hi) | ||
| if target_index < len(nums) and nums[target_index] == target: |
There was a problem hiding this comment.
上の考察では
i < hiを先にチェックすべき。
と書かれていますが、最終的にhiではなくtarget_index < len(nums)の比較にされたのは何か理由がありますでしょうか？
There was a problem hiding this comment.
ありがとうございます。
hiよりlen(nums)の方が認知負荷が少ないかな、となんとなく思い、そうしました。
（bisect_leftの上限値をとった場合はダメとするより、and nums[target_index] == targetを安全に行うためのフィルタリングを行い、全ての判定をand以降に任せる、みたいな感じでしょうか）
ですが、自分としてはどちらでも趣味の範囲内だと考えています。
|
|
||
| class Solution: | ||
| def search(self, nums: List[int], target: int) -> int: | ||
| key_function = lambda x: (x <= nums[-1], x) |
There was a problem hiding this comment.
なるほど、このような解き方もあるのですね。勉強になりました。
コードは短くなりますが、読む側としては少しパズルになるため実装１～２のほうが読みやすいかなと思いました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
この問題：https://leetcode.com/problems/search-in-rotated-sorted-array/
次の問題：https://leetcode.com/problems/capacity-to-ship-packages-within-d-days/