Increase versions only if necessary #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot is creating many PRs which require new versions of packages for no good reason. This new strategy will bump version constraints only when necessary, i.e. in order to get a major upgrade. Another strategy would be to let it widen the range, but it does not make much sense for a coding standard packages such as this one, since users are unlikely to have a dependency on the dependencies of this package. Note that we do have 2 dependencies that use pipes: - one is on PHP, and it makes sense to keep it; - one is on a package that is a composer plugin, and we might want to drop it once Composer 1 usages is deemed low enough.
Member
Author
|
Afterwards, let's see if #250 refreshes to use whatever this change should translate to. If not, I will push to the branch of that PR. |
ostrolucky
approved these changes
May 15, 2021
SenseException
approved these changes
May 15, 2021
alcaeus
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot is creating many PRs which require new versions of packages
for no good reason.
This new strategy will bump version constraints only when necessary,
i.e. in order to get a major upgrade.
Another strategy would be to let it widen the range, but it does not
make much sense for a coding standard packages such as this one, since
users are unlikely to have a dependency on the dependencies of this
package. Note that we do have 2 dependencies that use pipes:
drop it once Composer 1 usages is deemed low enough.
Closes #253 , closes #233