Skip to content

feat: require nowdoc syntax instead of heredoc when possible #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2022
Merged

feat: require nowdoc syntax instead of heredoc when possible #267

merged 1 commit into from
Jun 19, 2022

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Jun 19, 2022 •
edited
Loading

We use single quotes around strings, should do the same with <<<

@simPod simPod marked this pull request as ready for review June 19, 2022 15:22
@simPod simPod requested a review from a team as a code owner June 19, 2022 15:22
@greg0ire greg0ire merged commit 05e593b into doctrine:10.0.x Jun 19, 2022
@greg0ire
Copy link
Member

greg0ire commented Jun 19, 2022

Thanks @simPod !

@simPod simPod deleted the heredoc branch June 19, 2022 15:47
@simPod simPod mentioned this pull request Jun 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@greg0ire greg0ire greg0ire approved these changes

+1 more reviewer

@Ocramius Ocramius Ocramius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simPod @greg0ire @Ocramius @ostrolucky