Skip to content

Improve documentation about contributing #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2022
Merged

Improve documentation about contributing #285

merged 2 commits into from
Aug 26, 2022

Conversation

@greg0ire
Copy link
Member

@greg0ire greg0ire commented Aug 26, 2022

No description provided.

@greg0ire
Copy link
Member Author

greg0ire commented Aug 26, 2022

@simPod please review, in case you have better ideas on how to update the patches.

@greg0ire greg0ire requested review from derrabus and lcobucci August 26, 2022 12:18
@greg0ire greg0ire requested a review from a team August 26, 2022 13:04
@Ocramius Ocramius added this to the 10.0.1 milestone Aug 26, 2022
@Ocramius
Copy link
Member

Ocramius commented Aug 26, 2022

Hmm, did the release automation not create 10.1.x?

@greg0ire
Copy link
Member Author

greg0ire commented Aug 26, 2022

The state that does that seems to couple the branch creation and the switch to a new minor branch: https://github.com/laminas/automatic-releases/blob/5dbe6fc80071afda56c65e3d77f02575d6bc2300/examples/.github/workflows/release-on-milestone-closed.yml#L39-L47

Since our policy is to switch to the patch branch, it is disabled. So it would depend on the repository: https://github.com/doctrine/.github/blob/eefa7e134fcd134a83c66873796c334fae63d4a9/.github/workflows/release-on-milestone-closed.yml#L53

But I just noticed this one does not use a centralized workflow for some reason.

@greg0ire
Copy link
Member Author

greg0ire commented Aug 26, 2022

I'll create the branches manually. Regarding reusing the workflow, see #286

@ostrolucky ostrolucky merged commit ca88ad0 into doctrine:10.0.x Aug 26, 2022
@greg0ire greg0ire deleted the contributing branch August 26, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@derrabus derrabus Awaiting requested review from derrabus

+2 more reviewers

@Ocramius Ocramius Ocramius approved these changes

@lcobucci lcobucci lcobucci approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greg0ire @Ocramius @lcobucci @ostrolucky