feat: enable parent call spacing #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
parent-call
branch
6 times, most recently
from
dc621ff to
ef2f6ce
Compare
morozov
approved these changes
Sep 20, 2022
Ocramius
approved these changes
Sep 20, 2022
ostrolucky
requested changes
Sep 21, 2022
Member
ostrolucky
left a comment
ostrolucky
left a comment
There was a problem hiding this comment.
I don't think this one is worth it
greg0ire
approved these changes
Sep 21, 2022
Member
greg0ire
left a comment
greg0ire
left a comment
There was a problem hiding this comment.
We seem inconsistent regarding this, I think it's good we normalize it.
ostrolucky
approved these changes
Sep 21, 2022
Member
ostrolucky
left a comment
ostrolucky
left a comment
There was a problem hiding this comment.
Alright then. I'm not going to block this if most people want this.
lcobucci
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve readability by requiring one space around parent calls.