Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .doctrine-project.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,33 @@
"docsSlug": "doctrine-coding-standard",
"versions": [
{
"name": "9.0",
"branchName": "9.0.x",
"slug": "9.0",
"name": "11.0",
"branchName": "11.0.x",
"slug": "11.0",
"upcoming": true
},
{
"name": "8.2",
"branchName": "8.2.x",
"slug": "8.2",
"name": "10.0",
"branchName": "10.0.x",
"slug": "10.0",
"current": true,
"aliases": [
"current",
"stable"
]
},
{
"name": "9.0",
"branchName": "9.0.x",
"slug": "9.0",
"maintained": false
},
{
"name": "8.2",
"branchName": "8.2.x",
"slug": "8.2",
"maintained": false
},
{
"name": "8.1",
"branchName": "8.1.x",
Expand Down
41 changes: 6 additions & 35 deletions .github/workflows/release-on-milestone-closed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,38 +8,9 @@ on:
jobs:
release:
name: "Git tag, release & create merge-up PR"
runs-on: "ubuntu-20.04"

steps:
- name: "Checkout"
uses: "actions/checkout@v2"

- name: "Release"
uses: "laminas/automatic-releases@v1"
with:
command-name: "laminas:automatic-releases:release"
env:
"GITHUB_TOKEN": ${{ secrets.GITHUB_TOKEN }}
"SIGNING_SECRET_KEY": ${{ secrets.SIGNING_SECRET_KEY }}
"GIT_AUTHOR_NAME": ${{ secrets.GIT_AUTHOR_NAME }}
"GIT_AUTHOR_EMAIL": ${{ secrets.GIT_AUTHOR_EMAIL }}

- name: "Create Merge-Up Pull Request"
uses: "laminas/automatic-releases@v1"
with:
command-name: "laminas:automatic-releases:create-merge-up-pull-request"
env:
"GITHUB_TOKEN": ${{ secrets.GITHUB_TOKEN }}
"SIGNING_SECRET_KEY": ${{ secrets.SIGNING_SECRET_KEY }}
"GIT_AUTHOR_NAME": ${{ secrets.GIT_AUTHOR_NAME }}
"GIT_AUTHOR_EMAIL": ${{ secrets.GIT_AUTHOR_EMAIL }}

- name: "Create new milestones"
uses: "laminas/automatic-releases@v1"
with:
command-name: "laminas:automatic-releases:create-milestones"
env:
"GITHUB_TOKEN": ${{ secrets.GITHUB_TOKEN }}
"SIGNING_SECRET_KEY": ${{ secrets.SIGNING_SECRET_KEY }}
"GIT_AUTHOR_NAME": ${{ secrets.GIT_AUTHOR_NAME }}
"GIT_AUTHOR_EMAIL": ${{ secrets.GIT_AUTHOR_EMAIL }}
uses: "doctrine/.github/.github/workflows/release-on-milestone-closed.yml@2.0.0"
secrets:
GIT_AUTHOR_EMAIL: ${{ secrets.GIT_AUTHOR_EMAIL }}
GIT_AUTHOR_NAME: ${{ secrets.GIT_AUTHOR_NAME }}
ORGANIZATION_ADMIN_TOKEN: ${{ secrets.ORGANIZATION_ADMIN_TOKEN }}
SIGNING_SECRET_KEY: ${{ secrets.SIGNING_SECRET_KEY }}
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Contributing

See https://www.doctrine-project.org/projects/doctrine-coding-standard/en/stable/reference/index.html#contributing
34 changes: 26 additions & 8 deletions docs/en/reference/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,24 @@ and `the list of configuration options <https://github.com/squizlabs/PHP_CodeSni

To learn about customizing the rules, please refer to the :ref:`customizing` chapter.

Contributing
============

Versioning
==========
----------

This library follows semantic versioning, and additions to the code ruleset
are only performed in major releases.

The patch branch can receive internal changes, such as CI pipeline
improvements, test workflow improvements, and can receive bugfixes. For
instance, such as removing rules that were not meant to be added.

The minor branch can receive refactorings, and dependency updates that
do not affect the code ruleset.

Testing
=======
-------

If you are contributing to the Doctrine Coding Standard and want to test your contribution, you just
need to execute the ``test`` GNU make target:
Expand All @@ -136,13 +146,21 @@ need to execute the ``test`` GNU make target:
Sometimes you are enabling a sniff that enforces some features for a specific PHP version, that will
probably cause our build pipeline to fail when running on such versions.

We have created the ``update-compatibility-patch`` GNU make target to help you with that:
We have created the ``update-compatibility-patch-*`` GNU make targets to
help you with that. For instance, for PHP 6.0, you would run

.. code-block:: bash

$ make update-compatibility-patch
$ make update-compatibility-patch-60

That target will attempt to apply the latest version of our
compatibility patch for that version of PHP and ask you to adjust the
code in ``tests/fixed`` and ``tests/expected_report.txt`` using the
editor of your preference.

If the patch does not apply cleanly, you can edit it to edit or remove
hunks that relate to files you changed in your PR.

That target will apply the latest version of our compatibility patch and ask you to adjust the code in ``tests/fixed`` and
``tests/expected_report.txt`` using the editor of your preference.
Once you are done, please type "y" to resume the command, which will update the compatibility patch and create a commit
with your changes for you to push to your remote branch.
Once you are done, please type "y" to resume the command, which will
update the compatibility patch and create a commit with your changes for
you to push to your remote branch.