Merge 10.1.x up into 11.0.x #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People will be more likely to read this guide.
Reuse shared workflow
Update branch metadata
As per https://getcomposer.org/doc/04-schema.md#keywords by including "dev" as a keyword in the `composer.json` file, Composer 2.4.0-RC1 and later will prompt users if the package is installed with `composer require` instead of `composer require --dev`. See composer/composer#10960 for more info.
Merge 10.0.x up into 10.1.x
Upstream package has fixed a false positive with self::CONSTANT Here is how the false positive looked like > 9 | ERROR | [ ] Invalid inline documentation comment format "@var int", expected "@var type $variable Optional description". > | | (SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat) It was about these lines: > /** @var int */ > const FOO = 123;
Add "dev" Composer keyword
ostrolucky
approved these changes
Dec 10, 2022
Ocramius
approved these changes
Dec 10, 2022
Closed
SenseException
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to have to adjust tests, by first making them fail instead of crashing on
patchUPDATE: Done.