Fix counting of inverse collections with limit #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
approved these changes
Mar 24, 2017
Member
|
@alcaeus I was to click the "Merge" button but noticed that travis is not really happy, could you look into that? |
Member
Author
|
Yeah, I'll have to check what dependency needs a bump for this to work. |
malarzm
reviewed
Mar 24, 2017
| /** @ODM\Id */ | ||
| public $id; | ||
|
|
||
| /** @ODM\ReferenceMany(targetDocument=GH1572Post::class, mappedBy="blog") */ |
Member
There was a problem hiding this comment.
I guess that doctrine/annotations in lowest allowed version are not happy with this
alcaeus
force-pushed
the
fix-persistent-collection-count
branch
from
e7e8ad1 to
0951974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where having an inverse reference with a limit set would return the wrong number of elements when the collection isn't initialized.