Move LazyGhost deprecation to ProxyFactory #12101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/better-lazy-ghost-deprecation
branch
from
bbf1f78 to
d14c43b
Compare
derrabus
force-pushed
the
improvement/better-lazy-ghost-deprecation
branch
from
d14c43b to
7148fc7
Compare
greg0ire
approved these changes
Aug 4, 2025
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 4, 2025
* 3.5.x: Move LazyGhost deprecation to ProxyFactory (doctrine#12101) Address deprecations from doctrine/dbal (doctrine#12098)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 4, 2025
* 3.6.x: Move LazyGhost deprecation to ProxyFactory (doctrine#12101) Address deprecations from doctrine/dbal (doctrine#12098) Remove if statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Configuration::isNativeLazyObjectsEnabled()method is called quite often in our codebase. It shouldn't be necessary to check for an trigger a deprecation whenever we call that method. As a performance improvement, I therefore propose to trigger the deprecation only once when we create the proxy factory.