Skip to content

Conversation

dbu
Copy link
Member

@dbu dbu commented Aug 10, 2014

fix #458

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not possible, then should we be doing this further back in the query builder converter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone should actually try to confirm if its not possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it is not possible to use functions in an ORDER BY http://www.h2database.com/jcr/grammar.html#name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but .. this is not a Document Repository problem right? Shouldn't this logic be in QueryBuilder? We would presumeably get the same problem if we use the QueryBuilder directly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not possible, then should we be doing this further back in the query builder converter?

So this is not the right place? Can we revert it?

lsmith77 added a commit that referenced this pull request Aug 10, 2014
validate findBy arguments to not be about association mappings.
@lsmith77 lsmith77 merged commit 429ae2d into master Aug 10, 2014
@lsmith77 lsmith77 deleted the handle-unsupported-findby branch August 10, 2014 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw exception when trying to findBy wrong properties
3 participants