Skip to content

Conversation

@cmbankester
Copy link
Contributor

I noticed when using the closure-compiler gem to compile some ES6 code that it was breaking on the following code:

const foo = {
  delete(arg){
    return "foobar";
  }
};

The issue seemed to be with the fact that the key was named delete and that it's using ES6 object method shorthand. Updating the compiler jar to the latest (20151015) fixed the issue.

knowtheory added a commit that referenced this pull request Nov 12, 2015
Updated compiler jar file to 20151015
@knowtheory knowtheory merged commit bea781f into documentcloud:master Nov 12, 2015
@knowtheory
Copy link
Member

Thanks @cmbankester! we'll roll out a gem momentarily.

@cmbankester
Copy link
Contributor Author

Thanks! So speedy, I didn't even have time to update my rails apps Gemfiles to point to my fork!

@cmbankester
Copy link
Contributor Author

Oh, we should probably update the README to indicate the new version of the JAR

@knowtheory
Copy link
Member

Yep :) will do in the release process!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants