Skip to content

Conversation

@caciobanu
Copy link
Member

No description provided.

@redthor
Copy link
Contributor

redthor commented Aug 31, 2016

Great job @caciobanu !

Just a couple of things:

  • The build passed but there were two errors in this build. I am not sure if they're important:
    • this job is running on container-based infrastructure, which does not allow use of 'sudo',
    • PHP Strict standards: Declaration of AntiMattr\Tests\MongoDB\Migrations\Tools\Console\Command\StatusCommandStub::getMigrationConfiguration() should be compatible with that of AntiMattr\MongoDB\Migrations\Tools\Console\Command\AbstractCommand::getMigrationConfiguration() in /home/travis/build/doesntmattr/mongodb-migrations/tests/AntiMattr/Tests/MongoDB/Migrations/Tools/Console/Command/StatusCommandTest.php on line 218
  • could we get a 'build status' logo in the README?

@caciobanu
Copy link
Member Author

My answers below:

  • The first one is not an error but an info message to not use sudo if a specific config is not set.
  • For the PHP strict standards error I'll send another PR.
  • I will send a separate PR for the README update.

PS: I wanted to keep CI integration changes as minimal as possible so for future PR`s we have CI up and running.

@redthor redthor merged commit 5d37c6e into doesntmattr:master Aug 31, 2016
@redthor
Copy link
Contributor

redthor commented Aug 31, 2016

I did the README update in #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants