Skip to content

Conversation

kdeng
Copy link
Contributor

@kdeng kdeng commented Jun 19, 2025

No description provided.

@kdeng kdeng requested a review from neoakris June 19, 2025 11:54
@kdeng
Copy link
Contributor Author

kdeng commented Jun 19, 2025

@neoakris I just switched to use TargetGroupBinding CRD instead of ingress, and it seems to work as expected for both deploy and destroy.

@neoakris
Copy link
Collaborator

neoakris commented Jun 23, 2025

I merged integration into this to fix merge conflicts.
I'm currently deploying, will then destroy, and then will try to get this merged into integration today if things go smoothly. (changes & gameplan discussed over call, update me when ready for review again.)

@kdeng kdeng force-pushed the features/kefeng branch from 111f28d to aad04e8 Compare July 1, 2025 03:16
@kdeng kdeng force-pushed the features/csi-1655 branch from 7cebd43 to 7d4d68d Compare July 1, 2025 03:19
@kdeng kdeng force-pushed the features/kefeng branch from aad04e8 to 150da50 Compare July 1, 2025 03:20
@kdeng
Copy link
Contributor Author

kdeng commented Jul 1, 2025

@neoakris Yes, it is ready for review now. Thanks

@neoakris
Copy link
Collaborator

neoakris commented Jul 1, 2025

Cool. Just a heads up I'm PTO this week, so I'll check it out when I return on July 7th.

@neoakris
Copy link
Collaborator

neoakris commented Jul 8, 2025

had to comment out an account specific reference then it worked, the output was handy.

@neoakris neoakris merged commit 123cea0 into features/csi-1655 Jul 8, 2025
@neoakris neoakris deleted the features/kefeng branch July 8, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants