Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Sep 27, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Include a hash of the library name to ensure that css module idents are unique across dojo projects with the same structure and same module names.

Resolves #325

@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #326 into master will increase coverage by 0.48%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   47.83%   48.32%   +0.48%     
==========================================
  Files          10       10              
  Lines         692      685       -7     
  Branches      197      195       -2     
==========================================
  Hits          331      331              
+ Misses        361      354       -7
Impacted Files Coverage Δ
src/base.config.ts 19.29% <33.33%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398d259...0d933b3. Read the comment docs.

@agubler agubler merged commit 54a6082 into dojo:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS modules are not correctly hashed

2 participants