Adding glob for spec files as unit tests #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
=======================================
Coverage 48.53% 48.53%
=======================================
Files 10 10
Lines 684 684
Branches 193 193
=======================================
Hits 332 332
Misses 352 352
Continue to review full report at Codecov.
|
agubler
reviewed
Oct 25, 2019
src/unit.config.ts
Outdated
| config.entry = () => { | ||
| const unit = globby | ||
| .sync([`${basePath}/tests/unit/**/*.ts`]) | ||
| .sync([`${basePath}/tests/unit/**/*.ts`, `${basePath}/src/**/*.spec.{ts,tsx}`]) |
Member
There was a problem hiding this comment.
Should the other glob also include tsx? I know it's not part of these changes tho!
Contributor
Author
There was a problem hiding this comment.
I can get behind that change! Done!
matt-gadd
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettierDescription:
Adding a glob to discover
.spec.tsand.spec.tsxfiles in the source directory and include them in unit test builds.There are currently not tests for test builds, so I didn't add anything, but I manually tested this by adding a
test.spec.tsin thetest-app/srcdirectory and did a unit test build. I then manually verified that the test was included in the built bundle.Resolves #341