Align schema with usage #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@maier49 for options available on the command line kebab case is preferred so we shouldn't be changing the yargs options. For using in the dojorc, the schema changes look right, as kebab-case gets transformed to camel case by yargs. |
Contributor
Author
|
@agubler 👍 I removed the changes in |
matt-gadd
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettierDescription:
omit-hashandsingle-bundlein the schema and arg config don't align with the expected valuesomitHashandsingleBundlein the actual build config code. Most other properties seem to follow the camel case pattern so this applies the same to these properties.Resolves #410