Make text animation more palatable on mobile #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhager
reviewed
Oct 29, 2018
| var typing1Elem = document.querySelector('#upAndRunning-typing-1 .typed-text'); | ||
| var fontSize = window.getComputedStyle(typing1Elem, null).getPropertyValue('font-size'); | ||
| window.onresize = function() { |
Collaborator
There was a problem hiding this comment.
If this function was set to a local variable, it could be called above to set fontSize and would reduce duplication.
edhager
approved these changes
Oct 29, 2018
Collaborator
edhager
left a comment
edhager
left a comment
There was a problem hiding this comment.
I left one comment that would make the code a little nicer but isn't critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #482 which made the typing animations overflow on mobile