Loader plugin config

[cadorn]

In requirejs the plugin loader interface is:

define({
    load: function (name, req, onload, config) {

The dojo loader one is:

define({
    load: function (name, require, loaded) {

I need access to the config object in my plugin. The config object is the config passed to require during bootstrapping the loader.

Can you add something to the dojo loader plugin interface that will give me access to a config object I can set when bootstrapping the loader?

[kitsonk]

It is part of the AMD spec, so we should add it.

[maier49]

The LoaderPlugin interface in loader.ts is defined as
export interface LoaderPlugin {
dynamic?: boolean;
load?: (resourceId: string, require: Require, load: (value?: any) => void, config?: Object) => void;
normalize?: (moduleId: string, normalize: (moduleId: string) => string) => string;
}

It looks like load already has an optional config parameter.

[kitsonk]

@maier49 but it doesn't look like the loader passes it when it is called.

[tomdye]

Implemented and written tests, however, this highlighted an issue with our loader related to config being set every time a call to require is made: #48

The failing merge test made me think about how the plugin config would support these merged configs. Looks like the code needs to be revisited to allow any updated config to be merged with the config that we save and pass on to plugin load functions.