Skip to content

Conversation

@kitsonk
Copy link
Member

@kitsonk kitsonk commented Mar 9, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This allows the loader to load modules when running in a web worker environment.

Resolves #115

@codecov-io
Copy link

codecov-io commented Mar 9, 2017

Codecov Report

Merging #117 into master will decrease coverage by -1.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   84.97%   83.91%   -1.06%     
==========================================
  Files           1        1              
  Lines         539      547       +8     
  Branches      134      136       +2     
==========================================
+ Hits          458      459       +1     
- Misses         34       41       +7     
  Partials       47       47
Impacted Files Coverage Δ
_build/src/loader.ts 83.91% <0%> (-1.06%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6eaba...c9b1a9f. Read the comment docs.

@kitsonk
Copy link
Member Author

kitsonk commented Mar 9, 2017

There is an issue in that when the loader is run in a web worker, its coverage information isn't exposed. So while there is a functional test as part of this PR, it is showing that code is not covered. I suspect it would be a change to intern to post out coverage information from a web worker -> runner -> intern server.

@kitsonk
Copy link
Member Author

kitsonk commented Mar 9, 2017

Opened theintern/intern#721

Copy link
Member

@dylans dylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but you may want someone else to review.

@dylans dylans added this to the 2017.03 milestone Mar 9, 2017
@dylans dylans modified the milestones: 2017.03, 2017.04 Apr 2, 2017
@kitsonk kitsonk merged commit 0d4bbdb into master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants