Skip to content

Conversation

@kitsonk
Copy link
Member

@kitsonk kitsonk commented Jun 28, 2017

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

This PR pins the version of the tests against Firefox 52, the ESR version of Firefox, which resolves the failures that can be encountered.

Fixes #138

@codecov
Copy link

codecov bot commented Jun 28, 2017

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files           1        1           
  Lines         543      543           
  Branches      136      136           
=======================================
  Hits          465      465           
  Misses         32       32           
  Partials       46       46

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c2db2...c3be4c1. Read the comment docs.

@kitsonk kitsonk changed the title WIP: Investigations in #138 Fix failures on tests for Firefox Jun 28, 2017
@kitsonk kitsonk requested review from agubler and dylans June 28, 2017 13:51
@kitsonk kitsonk merged commit 51d1126 into dojo:master Jun 28, 2017
@dylans dylans added this to the 2017.06 milestone Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing with CSP under current versions of Firefox

3 participants