Skip to content

Conversation

@bryanforbes
Copy link
Member

Type: enhancement

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Resolves #142

@bryanforbes bryanforbes requested a review from rorticus October 13, 2017 14:37
@codecov
Copy link

codecov bot commented Oct 13, 2017

Codecov Report

Merging #145 into master will decrease coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   86.08%   84.98%   -1.11%     
==========================================
  Files           1        1              
  Lines         546      506      -40     
  Branches      133      133              
==========================================
- Hits          470      430      -40     
  Misses         32       32              
  Partials       44       44
Impacted Files Coverage Δ
src/loader.ts 84.98% <ø> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291fee3...f041026. Read the comment docs.

@bryanforbes bryanforbes requested a review from agubler October 13, 2017 21:06
Copy link
Member

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, ok to ignore the target code coverage due to simply changes in code, not in actual changes to coverage.

@bryanforbes bryanforbes merged commit 8190f6d into dojo:master Oct 16, 2017
@bryanforbes bryanforbes deleted the intern-4 branch October 16, 2017 16:05
@dylans dylans added this to the 2017.10 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants