Update for @dojo/widget-core changes #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitpshr
approved these changes
Sep 21, 2017
Member
bitpshr
left a comment
bitpshr
left a comment
There was a problem hiding this comment.
So no more registry just for registry's sake I guess? I like this, it's more obvious what's going on and way less boilerplate.
kitsonk
approved these changes
Sep 25, 2017
smhigley
reviewed
Sep 26, 2017
src/calendar/Calendar.ts
Outdated
| year | ||
| } = this._getMonthYear(); | ||
| const { theme = {} } = this.properties; | ||
| const { theme = {}, customDateCell } = this.properties; |
Contributor
There was a problem hiding this comment.
should this be updated to CustomDateCell to be consistent with the other case changes?
kitsonk
reviewed
Sep 26, 2017
package.json
Outdated
| "@dojo/interfaces": "next", | ||
| "@dojo/loader": "next", | ||
| "@dojo/test-extras": "next", | ||
| "@dojo/test-extras": "file:../../dojo-org/test-extras/dist/dojo-test-extras-2.0.0-alpha.1.tgz", |
Member
Author
|
@smhigley comments addressed |
smhigley
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
It's that time of year again where we need to update widgets inline with breaking changes from widget-core.
Main changes being
registryis no longer an accepted property forWidgetBase- Have updated to take the constructor directory and use.Requires release of test-extras