Textarea functional tests #324
Conversation
smhigley
left a comment
smhigley
left a comment
There was a problem hiding this comment.
Same comment about the extraClasses , but otherwise looks good
| }) | ||
| .end(); | ||
| }, | ||
| 'hidden label should not be displayed'() { |
There was a problem hiding this comment.
I'm not sure we need to add an example and test for this, since it's part of label functionality rather than textarea functionality (and I'm not a fan of hidden labels, so not big on modeling them in all the widget examples)
pottedmeat
force-pushed
the
textarea-functional-tests
branch
from
8a1229e to
8221990
Compare
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 25 25
Lines 1940 1940
Branches 491 491
=======================================
Hits 1897 1897
Misses 20 20
Partials 23 23Continue to review full report at Codecov.
|
src/textarea/example/index.ts
Outdated
| }), | ||
| v('h3', {}, ['Validated, Required Textarea']), | ||
| w(Textarea, { | ||
| extraClasses: { root: 't3' }, |
There was a problem hiding this comment.
same comment as others re. wrapping div with class rather than extraClasses.
pottedmeat
force-pushed
the
textarea-functional-tests
branch
3 times, most recently
from
4c6d6c9 to
11334bb
Compare
pottedmeat
force-pushed
the
textarea-functional-tests
branch
from
11334bb to
745e838
Compare
6 participants
Type: feature
The following has been addressed in the PR:
Description:
Resolves #160