Add paging aria semantics, update pageChange #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 98.87% 98.94% +0.06%
==========================================
Files 42 42
Lines 3035 3040 +5
Branches 816 820 +4
==========================================
+ Hits 3001 3008 +7
+ Misses 34 32 -2
Continue to review full report at Codecov.
|
smhigley
force-pushed
the
grid-paging
branch
from
c4f0fbe to
8c75fcd
Compare
agubler
approved these changes
Sep 21, 2018
smhigley
force-pushed
the
grid-paging
branch
from
8c75fcd to
c1cc496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Resolves #585
Adds ARIA attributes for row count and index to handle not all rows existing in the DOM. Also adds ARIA attribute for column sorting.
Updates
pageChangepage numbering logic. Previously, when the grid fetched more rows at once than existing in a single page, it was possible to never land on the first page.