add on_starknet_event #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larkooo
requested changes
Oct 18, 2024
src/wasm/mod.rs
Outdated
| let mut stream = stream.take_until_if(tripwire.clone()); | ||
|
|
||
| while let Some(Ok(event)) = stream.next().await { | ||
| // subscription_id_clone.store(id, Ordering::SeqCst); |
There was a problem hiding this comment.
Let's remove these lines, since starknet event subscriptions dont have subscription IDs.
src/wasm/mod.rs
Outdated
|
|
||
| // Spawn a new task to handle the stream and reconnections | ||
| let client = self.inner.clone(); | ||
| // let subscription_id_clone = Arc::clone(&subscription_id); |
There was a problem hiding this comment.
Let's remove these lines, since starknet event subscriptions dont have subscription IDs.
Larkooo
reviewed
Oct 18, 2024
notV4l
force-pushed
the
on_starknet_event
branch
from
6926511 to
c238adc
Compare
notV4l
force-pushed
the
on_starknet_event
branch
2 times, most recently
from
15354e6 to
f375d20
Compare
notV4l
force-pushed
the
on_starknet_event
branch
from
7d802ef to
896c2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.