Skip to content

Conversation

@tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Oct 31, 2025

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • Chores
    • Bumped package versions from 1.7.2 to 1.8.0 across workspace packages and public version constant.
    • Updated example dev config with a new world address.
    • Simplified CLI warning message for overridden addresses.
  • Tests
    • CI test workflow updated to download the non-alpha Katana release (v1.7.0).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Ohayo sensei!

Walkthrough

Workspace and crate manifest versions bumped from 1.7.2 → 1.8.0 across multiple Cargo/Scarb files, the Cairo world contract WORLD_VERSION constant updated to 1.8.0, the GitHub Actions Katana URL changed from the alpha tag to release v1.7.0, and an example env.world_address value was updated.

Changes

Cohort / File(s) Summary
Root workspace
Cargo.toml
Workspace package version updated from 1.7.21.8.0
Dojo core & tests
crates/dojo/core/Scarb.toml, crates/dojo/core-tests/Scarb.toml, crates/dojo/dojo-cairo-test/Scarb.toml, crates/dojo/dojo-snf-test/Scarb.toml
Package versions bumped 1.7.21.8.0
Cairo world contract
crates/dojo/core/src/world/world_contract.cairo
pub const WORLD_VERSION changed from '1.7.2''1.8.0'
Macro test
crates/macros/merge-options/macro_test/Cargo.toml
Crate version bumped 1.7.21.8.0
Examples
examples/game-lib/Scarb.toml, examples/game-lib/armory/Scarb.toml, examples/game-lib/bestiary/Scarb.toml, examples/simple/Scarb.toml, examples/spawn-and-move/Scarb.toml, examples/spawn-and-move/external/Scarb.toml
Example package versions bumped 1.7.21.8.0
Example env
examples/spawn-and-move/dojo_dev.toml
env.world_address value changed (address updated)
CI workflow
.github/workflows/test.yml
Katana download URL updated to use release tag v1.7.0 (replaced v1.7.0-alpha.3 path)
CLI utils
bin/sozo/src/utils.rs
Replaced a multi-line de-duplication warning block with a concise single-line ui.warn(...) message when deterministic and config addresses differ

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Mostly homogeneous manifest version bumps plus a single constant, CI URL change, one example env update, and a small UX message simplification.
  • Pay attention to:
    • crates/dojo/core/src/world/world_contract.cairo — ensure WORLD_VERSION constant value format/type matches expectations.
    • .github/workflows/test.yml — confirm Katana URL and tarball path are correct for the release tag.
    • examples/spawn-and-move/dojo_dev.toml — validate the updated world_address value.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "release(prepare): v1.8.0" directly and clearly summarizes the main objective of this pull request, which is to prepare version 1.8.0 for release. The changeset predominantly consists of version bumps from 1.7.2 to 1.8.0 across multiple manifest files (Cargo.toml, Scarb.toml) and the WORLD_VERSION constant, which aligns perfectly with the title's intent. The title uses a conventional commit format that is specific, concise, and free of vague terminology, making it clear to anyone reviewing the git history that this is a release preparation commit.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prepare-release

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 719691f and 51f1b3b.

📒 Files selected for processing (1)
  • bin/sozo/src/utils.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: clippy
🔇 Additional comments (1)
bin/sozo/src/utils.rs (1)

78-81: Ohayo sensei! This UX improvement LGTM!

The refactor from ui.warn_block(...) to ui.warn(...) is a clean improvement. The concise warning message clearly communicates both addresses in hex format while maintaining the same control flow. The formatting is consistent with the rest of the codebase.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@glihm glihm merged commit 843d276 into main Oct 31, 2025
10 checks passed
@glihm glihm deleted the prepare-release branch October 31, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants