correct evolution api docker image to the latest one and implement missing configuration for the latest features #429
correct evolution api docker image to the latest one and implement missing configuration for the latest features #429mrj0b wants to merge 5 commits intoDokploy:canaryfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
|
don't merge yet i'll make other changes to implement configurations for all the new features on the latest version to makes them work |
mrj0b
changed the title
…or the latest features to work properly
mrj0b
changed the title
|
ready for review and merge |
|
matheusfelipeog
left a comment
matheusfelipeog
left a comment
There was a problem hiding this comment.
Hi @mrj0b. Nice contribution, thank you. I’m not a maintainer of the project, but I ran into a similar issue and ended up here on your PR.
I left some suggestions about the changes you made. Take a look at them and let me know if they make sense to you, if you agree.
| - LANGUAGE=${LANGUAGE} | ||
| - CONFIG_SESSION_PHONE_CLIENT=${CONFIG_SESSION_PHONE_CLIENT} | ||
| - CONFIG_SESSION_PHONE_NAME=${CONFIG_SESSION_PHONE_NAME} | ||
| - CONFIG_SESSION_PHONE_VERSION=${CONFIG_SESSION_PHONE_VERSION} |
There was a problem hiding this comment.
| - CONFIG_SESSION_PHONE_VERSION=${CONFIG_SESSION_PHONE_VERSION} |
The variable CONFIG_SESSION_PHONE_VERSION no longer exists in the project.
The value used internally started being automatically populated in version v2.3.0.
It was completely removed in version v2.3.1.
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API", | ||
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API V2", | ||
| "CONFIG_SESSION_PHONE_NAME=Chrome", | ||
| "CONFIG_SESSION_PHONE_VERSION=2.3000.1026420114", |
There was a problem hiding this comment.
| "CONFIG_SESSION_PHONE_VERSION=2.3000.1026420114", |
Same as #review
| "AUTHENTICATION_EXPOSE_IN_FETCH_INSTANCES=true", | ||
| "LANGUAGE=en", | ||
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API", | ||
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API V2", |
There was a problem hiding this comment.
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API V2", | |
| "CONFIG_SESSION_PHONE_CLIENT=Evolution API", |
I don’t think this is necessary and it might cause some confusion. It would also require updating with every new major release.
What was originally there is fine and already makes clear what it refers to. The Evolution API version is also displayed next to the name in the interface.
| "OPENAI_ENABLED=true", | ||
| "DIFY_ENABLED=true", | ||
| "FLOWISE_ENABLED=true", | ||
| "N8N_ENABLED=true", | ||
| "TYPEBOT_ENABLED=true", | ||
| "TYPEBOT_API_VERSION=latest", | ||
| "CHATWOOT_ENABLED=true", | ||
| "CHATWOOT_MESSAGE_READ=true", | ||
| "CHATWOOT_MESSAGE_DELETE=true", | ||
| "CHATWOOT_IMPORT_DATABASE_CONNECTION_URI=chatwoot", | ||
| "CHATWOOT_IMPORT_PLACEHOLDER_MEDIA_MESSAGE=true", |
There was a problem hiding this comment.
| "OPENAI_ENABLED=true", | |
| "DIFY_ENABLED=true", | |
| "FLOWISE_ENABLED=true", | |
| "N8N_ENABLED=true", | |
| "TYPEBOT_ENABLED=true", | |
| "TYPEBOT_API_VERSION=latest", | |
| "CHATWOOT_ENABLED=true", | |
| "CHATWOOT_MESSAGE_READ=true", | |
| "CHATWOOT_MESSAGE_DELETE=true", | |
| "CHATWOOT_IMPORT_DATABASE_CONNECTION_URI=chatwoot", | |
| "CHATWOOT_IMPORT_PLACEHOLDER_MEDIA_MESSAGE=true", | |
| "OPENAI_ENABLED=false", | |
| "DIFY_ENABLED=false", | |
| "FLOWISE_ENABLED=false", | |
| "N8N_ENABLED=false", | |
| "TYPEBOT_ENABLED=false", | |
| "TYPEBOT_API_VERSION=latest", | |
| "CHATWOOT_ENABLED=false", | |
| "CHATWOOT_MESSAGE_READ=false", | |
| "CHATWOOT_MESSAGE_DELETE=false", | |
| "CHATWOOT_IMPORT_DATABASE_CONNECTION_URI=", | |
| "CHATWOOT_IMPORT_PLACEHOLDER_MEDIA_MESSAGE=false", |
I read the issues you opened and I understand your point. I don’t think it’s a good idea to set the variables that enable integrations with external platforms/resources to true by default --- especially since this is meant to serve as a template for others to use --- just like you didn’t enable RABBITMQ, SQS, WEBSOCKET, etc. by default. Not everyone will use the same features you do.
I suggest keeping the same default values provided by the Evolution API itself in the .env.example and env.example files. The template user should be responsible for enabling the features they need for their instance.
What do you think about that?
p.s. I haven’t checked all the variables you defined here, but the same idea applies to any others as well.
|
|
||
| x-base-config: &base-config | ||
| image: chatwoot/chatwoot:v4.0.3 | ||
| image: chatwoot/chatwoot:latest |
There was a problem hiding this comment.
We shouldn't use latest images, this can break the templates easily
|
@mrj0b what do you think about the suggested changes? |
|
Close due to inacitivty |
5 participants
fix for 428 and 430