Skip to content

Conversation

@kutenai
Copy link

@kutenai kutenai commented Feb 9, 2019

I am running the beta version since I need Django 2.1 support.
I found that I had to create this migration, so I want ahead and forked it, and submitting the PR.
It would be nice to get this into the mainline soon.

@kutenai
Copy link
Author

kutenai commented Feb 9, 2019

Wow... All checks faile? I just added a migration.
The tests passed locally, but I did not try all of the different python versions, just running 3.7
will have to look into this more.
If anyone can point out what I did wrong... I'd appreciate that also.

@kutenai
Copy link
Author

kutenai commented Feb 9, 2019

This does fail locally with the same issue. It looks like this fails on master also.

@kutenai
Copy link
Author

kutenai commented Mar 17, 2019

It looks like this was merged in, or just done locally, so this PR isn't needed anymore.

@kutenai kutenai closed this Mar 17, 2019
@kutenai
Copy link
Author

kutenai commented Mar 17, 2019

It looks like this was merged in, or just done locally, so this PR isn't needed anymore.

@kutenai kutenai reopened this Mar 17, 2019
@kutenai
Copy link
Author

kutenai commented Mar 17, 2019

Oh, never mind.. I just realized this has NOT been merged, it's just that my local version has it. This does need to be merged into the main and released since the current branch isn't usable without the migration.

The checked might pass now due to time zone?? will see

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.635% when pulling c94b1b2 on sharpertool:add_missing_migration into 30c3ec3 on dokterbob:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.635% when pulling c94b1b2 on sharpertool:add_missing_migration into 30c3ec3 on dokterbob:master.

@dokterbob
Copy link
Collaborator

Superseded by #282 (now in master).

@dokterbob dokterbob closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants